chore(github): Use newly created teams to define code owners #3216
Conversation
Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
requested review from
MarcelBochtler,
bs-ondem,
nnobelis,
oheger-bosch,
sschuberth and
wkl3nk
as code owners
|
Teams need write access to the repository before they can be used as code owners. |
|
Note that a downside of using teams might be that GitHub then only requires one team member to start a review, and from then on only that member is listed as a reviewer, and the team is removed. At least that's the behavior I see in ORT. The problem with this is that if the original reviewer does not complete the review / approve, then no other reviewers will be added back automatically. |
|
We actually had a discussion about this exact topic at OSS Summit Europe with @schr3gl3j and others, coming to the conclusion that keeping the explicit names is more transparent to contributors, and also allows for a more fine-granular configuration of code owners. So I'd actually propose to drop this PR, and also revert to explicit user names .in |
Fine with me. |
|
@sschuberth I have made the change for ORT here: oss-review-toolkit/ort#10818 |
No description provided.